Sriniketh24 commented on PR #50024: URL: https://github.com/apache/arrow/pull/50024#issuecomment-5243191020
Hi @AlenkaF — thanks for the pointer to #38504, that was a good approach that just ran out of the original author's time (credit to @llama90 for the initial work, and @js8544 for reviewing it there). Reworked this PR to build on that approach: - Swapped the manual `int64_t` multiplication for `arrow::internal::MultiplyWithOverflow`, since the previous approach could itself silently overflow for 64-bit offset types (large_string/large_binary) — using the type-generic overflow-safe helper avoids that. - Added the length-exceeds-offset-type check and the negative-length check at `MakeArrayFromScalar`, matching what was validated in #38504. - Kept the existing Python-level `pa.repeat()` regression test from this PR as additional coverage beyond the C++-only tests in #38504. Note: I wasn't able to run the full C++ test suite in my local environment (no existing build directory / ninja), so I only syntax-checked the changed file directly against the local headers (clean, no errors). CI here will be the real validation — flagging that up front rather than claiming more confidence than I have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
