amoeba commented on code in PR #4671:
URL: https://github.com/apache/arrow-adbc/pull/4671#discussion_r3752174551
##########
dev/release/verify-release-candidate.ps1:
##########
@@ -237,9 +254,136 @@ if ($TestSource) {
if (-not $?) { exit 1 }
}
-if ($TestBinaries) {
+if ($TestBinaryArtifacts) {
Show-Header "Verify Binary Distribution"
+ if ($TestWheels) {
+ Show-Header "Verify Python Wheels"
+
+ $IsWindowsPlatform = $env:OS -eq "Windows_NT"
+ if ($IsWindowsPlatform) {
+ if ($env:PROCESSOR_ARCHITECTURE -ne "AMD64") {
+ throw "Unsupported Windows architecture:
$($env:PROCESSOR_ARCHITECTURE)"
+ }
+ $Platform = "windows"
+ $PlatformPattern = "win_amd64"
+ $Architecture = "amd64"
+ } else {
Review Comment:
Do we really want to support running this on non-Windows platforms?
I tested on macOS just out of curiosity and got an error about the
`m2w64-gcc` package not being available so I think this script, either before
this PR or with this PR, only works on Windows anyways (unless we stop
depending on m2w64-gcc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
