zanmato1984 commented on PR #50843: URL: https://github.com/apache/arrow/pull/50843#issuecomment-5245130206
Could we avoid adding a new public virtual API on `DataType` for this? This code is already in an `is_fixed_width(...)` path, and Arrow already has existing patterns that size fixed-width buffers from `FixedWidthType::bit_width()` plus `bit_util::BytesForBits(length * bit_width)`, which also handles bit-packed boolean correctly. Maybe add a small local helper in `vector_replace.cc` and use it for `FillNullForwardChunked` / `FillNullBackwardChunked`, and also `ReplaceMaskChunked`, which still has the same `byte_width() * chunk->length()` issue for chunked boolean arrays. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
