cakeni opened a new pull request, #10631: URL: https://github.com/apache/arrow-rs/pull/10631
# Which issue does this PR close? - Part of #10245. # Rationale for this change Using `Vec` instead of `BufferBuilder` can benefit from Rust's optimized vector implementation. This updates the two builders used by the run-end encoded take path. # What changes are included in this PR? - Replace the run-end and value-index `BufferBuilder` instances in `take_run` with preallocated vectors. - Push values directly and construct the final `ScalarBuffer` objects from those vectors. - Leave the unrelated fixed-size binary `BufferBuilder` path unchanged. # Are these changes tested? Yes. The following checks pass: - `cargo +stable-x86_64-pc-windows-gnu fmt --all -- --check` - `cargo +stable-x86_64-pc-windows-gnu clippy -p arrow-select --all-targets --all-features --no-deps -- -D warnings` - `cargo +stable-x86_64-pc-windows-gnu test -p arrow-select --all-features` (406 unit tests and 17 doctests passed) # Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
