zeroshade commented on code in PR #1152:
URL: https://github.com/apache/arrow-go/pull/1152#discussion_r3761276712
##########
arrow/flight/flightsql/driver/driver.go:
##########
@@ -624,6 +624,10 @@ func (c *Connection) Begin() (driver.Tx, error) {
}
func (c *Connection) BeginTx(ctx context.Context, opts sql.TxOptions)
(driver.Tx, error) {
+ if opts.Isolation != sql.LevelDefault || opts.ReadOnly {
Review Comment:
This check is not reached through `database/sql`: `Connection.BeginTx`
accepts `sql.TxOptions`, but `driver.ConnBeginTx` requires `driver.TxOptions`.
Consequently, `*Connection` does not implement `driver.ConnBeginTx`;
`database/sql` bypasses this method, rejects non-default options with its own
generic errors, and falls back to `Begin()` for default transactions without
forwarding the caller’s context. Please expose the proper interface
hook—directly or through an adapter—add a compile-time interface assertion, and
exercise the behavior through `sql.DB.BeginTx`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
