zeroshade commented on code in PR #1148:
URL: https://github.com/apache/arrow-go/pull/1148#discussion_r3761871129
##########
arrow/csv/transformer.go:
##########
@@ -31,6 +31,9 @@ func (w *Writer) transformColToStringArr(typ arrow.DataType,
col arrow.Array, st
if w.customTypeConverter != nil {
result, handled := w.customTypeConverter(typ, col)
if handled {
+ if len(result) != col.Len() {
Review Comment:
This correctly validates against `col.Len()`, but the public
`WithCustomTypeConverter` documentation in `common.go` currently says the
returned slice must match “the number of columns in the output csv.” Since this
callback handles one column at a time, that should say it must contain one
string per row/value in `col`. Could we update that documentation alongside the
new validation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
