Copilot commented on code in PR #50187:
URL: https://github.com/apache/arrow/pull/50187#discussion_r3763871494
##########
cpp/src/gandiva/tests/CMakeLists.txt:
##########
@@ -51,6 +51,24 @@ if(ARROW_BUILD_STATIC)
"gandiva"
EXTRA_LINK_LIBS
gandiva_static)
+
+ # Calls the precompiled REPLACE functions directly, so it compiles
+ # string_ops.cc/context_helper.cc with GANDIVA_UNIT_TEST=1 (which exposes
them
+ # as linkable symbols). Only built when ARROW_BUILD_BENCHMARKS is ON.
Review Comment:
The comment mentions compiling both string_ops.cc and context_helper.cc with
GANDIVA_UNIT_TEST=1, but this target only compiles ../precompiled/string_ops.cc
directly; context_helper.cc comes from gandiva_static (and won’t be affected by
the target’s compile definitions). Please update the comment to match the
actual build wiring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
