Copilot commented on code in PR #50802:
URL: https://github.com/apache/arrow/pull/50802#discussion_r3764579220
##########
python/pyarrow/includes/libarrow_acero.pxd:
##########
@@ -42,6 +42,9 @@ cdef extern from "arrow/acero/options.h" namespace
"arrow::acero" nogil:
CTableSourceNodeOptions(shared_ptr[CTable] table)
CTableSourceNodeOptions(shared_ptr[CTable] table, int64_t
max_batch_size)
+ cdef cppclass CRecordBatchReaderSourceNodeOptions
"arrow::acero::RecordBatchReaderSourceNodeOptions"(CExecNodeOptions):
+ CRecordBatchReaderSourceNodeOptions(shared_ptr[CRecordBatchReader]
reader)
Review Comment:
`RecordBatchReaderSourceNodeOptions`' C++ constructor takes an optional
`arrow::internal::Executor* io_executor` parameter (with a default), but the
Cython declaration only includes the single-argument overload. This will fail
to compile when calling `new
CRecordBatchReaderSourceNodeOptions(reader.reader)` because there is no
one-argument constructor at the ABI level; the default argument is part of the
two-argument signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
