Rich-T-kid commented on code in PR #10654:
URL: https://github.com/apache/arrow-rs/pull/10654#discussion_r3769443566
##########
parquet/src/file/properties.rs:
##########
@@ -880,6 +894,24 @@ impl WriterPropertiesBuilder {
self
}
+ /// Enable or disable writing the distinct value count
(`num_distinct_values`) into
+ /// row group column chunk statistics (defaults to `false` via
+ /// [`DEFAULT_WRITE_ROW_GROUP_NUMBER_DISTINCT_VALUES`]).
+ ///
+ /// When enabled, the [`ArrowWriter`] scans each column's values before
encoding
+ /// and stores the number of distinct non-null values in the row group
statistics
+ /// footer.
+ ///
+ /// # Performance
+ ///
+ /// Computing the distinct count requires hashing every non-null value in
the column.
+ /// For large row groups or columns with many values this adds measurable
overhead.
+ /// Benchmark your workload before enabling this globally.
Review Comment:
> I think I'd prefer "significant" to "measurable".
@etseidl updated it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
