sdf-jkl commented on code in PR #10635:
URL: https://github.com/apache/arrow-rs/pull/10635#discussion_r3770497837
##########
parquet-variant-compute/src/shred_variant.rs:
##########
@@ -2898,6 +2911,49 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_variant_schema_builder_list() -> Result<()> {
+ let shredding_type = ShreddedSchemaBuilder::default()
+ .with_path("items[0].id", &DataType::Int64)?
+ .with_path("items[42].name", &DataType::Utf8)?
Review Comment:
I still wonder if we should allow number other than 0 or allow numbers at
all. I guess it's an open question.
I like the jsonpath style with [*] -
https://www.rfc-editor.org/rfc/rfc9535.html#section-2.3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
