Copilot commented on code in PR #50853:
URL: https://github.com/apache/arrow/pull/50853#discussion_r3771121679
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/odbc_descriptor.cc:
##########
@@ -215,7 +215,7 @@ void ODBCDescriptor::SetField(SQLSMALLINT record_number,
SQLSMALLINT field_ident
has_bindings_changed_ = true;
break;
case SQL_DESC_NAME:
- SetAttributeUTF8(value, buffer_length, record.name);
+ SetAttributeSQLWCHAR(value, buffer_length, record.name);
Review Comment:
The new test only exercises `SQL_ATTR_CURRENT_CATALOG`; this independent
`SQL_DESC_NAME` decoder change remains untested. Add a descriptor test that
sets a multi-character `SQLWCHAR` name with a byte length and verifies the
stored/read-back UTF-8 value, so this regression cannot recur unnoticed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
