AntoinePrv commented on code in PR #50827:
URL: https://github.com/apache/arrow/pull/50827#discussion_r3774191505


##########
python/pyarrow/tensor.pxi:
##########
@@ -310,20 +310,45 @@ strides: {self.strides}"""
             A Python integer representing a pointer to a stream. Currently not 
supported.
             Stream is provided by the consumer to the producer to instruct the 
producer
             to ensure that operations can safely be performed on the array.
+        max_version : tuple[int, int], optional
+            The maximum DLPack version the consumer supports, as (major, 
minor).
+            A capsule of a different version may be returned, so the consumer 
must
+            check it. Default is None, exporting the unversioned capsule.
+        dl_device : tuple[enum.Enum, int], optional
+            The device of the exported capsule, in the format returned by
+            :meth:`__dlpack_device__`. Default is None, meaning the device of 
the
+            tensor itself. Since only CPU tensors are supported, any other 
device
+            raises ``BufferError``.
+        copy : bool, optional
+            If True, the data is always copied. If False, it is never copied 
and
+            ``BufferError`` is raised if a copy is required. If None 
(default), the
+            data is copied only if needed, which for CPU tensors is never.

Review Comment:
   Converting to `False` on the Python side.
   That way we keep the official function signature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to