sdf-jkl commented on code in PR #10598:
URL: https://github.com/apache/arrow-rs/pull/10598#discussion_r3775690617
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -1815,4 +1813,24 @@ mod test {
),]),
"Cast error: Cast failed at index 0 (array type: Decimal128(38, 10)):
Invalid argument error: 123456789012345678901234567890123456789 is wider than
max precision 38"
);
+ #[test]
+ fn try_value_errors_on_unimplemented_typed_value_type() {
+ use crate::{json_to_variant, shred_variant};
+ use arrow::array::StringArray;
+
+ let json: ArrayRef = Arc::new(StringArray::from(vec![r#"{"qty":
3}"#]));
+ let variant = json_to_variant(&json).unwrap();
+ let shred_type = DataType::Struct(vec![Field::new("qty",
DataType::Int64, true)].into());
+ let shredded = shred_variant(&variant, &shred_type).unwrap();
+ // Object-shredded typed_value is not yet implemented: reading it must
+ // error, never silently return Variant::Null
+ // https://github.com/apache/arrow-rs/issues/10597
Review Comment:
```suggestion
// TODO: https://github.com/apache/arrow-rs/issues/10620
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
