domibel commented on code in PR #50799:
URL: https://github.com/apache/arrow/pull/50799#discussion_r3789811916
##########
cpp/src/gandiva/engine.cc:
##########
@@ -140,6 +140,9 @@ Result<llvm::orc::JITTargetMachineBuilder>
MakeTargetMachineBuilder(
const Configuration& conf) {
llvm::orc::JITTargetMachineBuilder jtmb(
(llvm::Triple(llvm::sys::getDefaultTargetTriple())));
+#if defined(__riscv)
+ jtmb.setRelocationModel(llvm::Reloc::PIC_);
+#endif
Review Comment:
Reloc::PIC_ was actually the default and #49063 changed it to Reloc::Static
as a side effect.
https://github.com/llvm/llvm-project/blob/release/21.x/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp#L801-L839
So it looks safe to drop the riscv guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
