Copilot commented on code in PR #50881: URL: https://github.com/apache/arrow/pull/50881#discussion_r3790309021
########## docs/source/cpp/tutorials/datasets_tutorial.rst: ########## @@ -66,6 +66,15 @@ compute functionality for each file type we'll work with in this article: :start-after: (Doc section: Includes) :end-before: (Doc section: Includes) +.. note:: + The dataset and Parquet headers come from libraries separate from ``arrow``, + so linking ``Arrow::arrow_shared`` alone is not enough to build this example. + Your ``CMakeLists.txt`` needs ``find_package(ArrowDataset REQUIRED)`` and + ``find_package(Parquet REQUIRED)``, linking both the + ``ArrowDataset::arrow_dataset_shared`` and ``Parquet::parquet_shared`` + targets. See :ref:`cpp-build-system-linking-parquet` for a complete + ``CMakeLists.txt``. Review Comment: This note says linking `Arrow::arrow_shared` alone is insufficient, but then it only lists `ArrowDataset` + `Parquet` packages/targets. That can read as “don’t link Arrow at all”, which is confusing for a tutorial still using core Arrow APIs. Consider explicitly listing `find_package(Arrow REQUIRED)` and `Arrow::arrow_shared` as part of the required CMake setup (in addition to dataset + parquet). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
