kou commented on code in PR #50877:
URL: https://github.com/apache/arrow/pull/50877#discussion_r3790387246
##########
cpp/src/parquet/reader_test.cc:
##########
@@ -1142,17 +1142,17 @@ TEST_F(TestJSONWithLocalFile, JSONOutput) {
"NumberOfRealColumns": "11",
"NumberOfColumns": "11",
"Columns": [
- { "Id": "0", "Name": "id", "PhysicalType": "INT32", "ConvertedType":
"NONE", "LogicalType": {"Type": "None"} },
- { "Id": "1", "Name": "bool_col", "PhysicalType": "BOOLEAN",
"ConvertedType": "NONE", "LogicalType": {"Type": "None"} },
- { "Id": "2", "Name": "tinyint_col", "PhysicalType": "INT32",
"ConvertedType": "NONE", "LogicalType": {"Type": "None"} },
- { "Id": "3", "Name": "smallint_col", "PhysicalType": "INT32",
"ConvertedType": "NONE", "LogicalType": {"Type": "None"} },
- { "Id": "4", "Name": "int_col", "PhysicalType": "INT32", "ConvertedType":
"NONE", "LogicalType": {"Type": "None"} },
- { "Id": "5", "Name": "bigint_col", "PhysicalType": "INT64",
"ConvertedType": "NONE", "LogicalType": {"Type": "None"} },
- { "Id": "6", "Name": "float_col", "PhysicalType": "FLOAT",
"ConvertedType": "NONE", "LogicalType": {"Type": "None"} },
- { "Id": "7", "Name": "double_col", "PhysicalType": "DOUBLE",
"ConvertedType": "NONE", "LogicalType": {"Type": "None"} },
- { "Id": "8", "Name": "date_string_col", "PhysicalType": "BYTE_ARRAY",
"ConvertedType": "NONE", "LogicalType": {"Type": "None"} },
- { "Id": "9", "Name": "string_col", "PhysicalType": "BYTE_ARRAY",
"ConvertedType": "NONE", "LogicalType": {"Type": "None"} },
- { "Id": "10", "Name": "timestamp_col", "PhysicalType": "INT96",
"ConvertedType": "NONE", "LogicalType": {"Type": "None"} }
+ { "Id": "0", "Name": "id", "PhysicalType": "INT32", "ConvertedType":
"NONE", "LogicalType": {"Type":"None"} },
+ { "Id": "1", "Name": "bool_col", "PhysicalType": "BOOLEAN",
"ConvertedType": "NONE", "LogicalType": {"Type":"None"} },
+ { "Id": "2", "Name": "tinyint_col", "PhysicalType": "INT32",
"ConvertedType": "NONE", "LogicalType": {"Type":"None"} },
+ { "Id": "3", "Name": "smallint_col", "PhysicalType": "INT32",
"ConvertedType": "NONE", "LogicalType": {"Type":"None"} },
+ { "Id": "4", "Name": "int_col", "PhysicalType": "INT32", "ConvertedType":
"NONE", "LogicalType": {"Type":"None"} },
+ { "Id": "5", "Name": "bigint_col", "PhysicalType": "INT64",
"ConvertedType": "NONE", "LogicalType": {"Type":"None"} },
+ { "Id": "6", "Name": "float_col", "PhysicalType": "FLOAT",
"ConvertedType": "NONE", "LogicalType": {"Type":"None"} },
+ { "Id": "7", "Name": "double_col", "PhysicalType": "DOUBLE",
"ConvertedType": "NONE", "LogicalType": {"Type":"None"} },
+ { "Id": "8", "Name": "date_string_col", "PhysicalType": "BYTE_ARRAY",
"ConvertedType": "NONE", "LogicalType": {"Type":"None"} },
+ { "Id": "9", "Name": "string_col", "PhysicalType": "BYTE_ARRAY",
"ConvertedType": "NONE", "LogicalType": {"Type":"None"} },
+ { "Id": "10", "Name": "timestamp_col", "PhysicalType": "INT96",
"ConvertedType": "NONE", "LogicalType": {"Type":"None"} }
Review Comment:
Could you use `JsonWriter` in
https://github.com/apache/arrow/blob/f64e90ac8305c2cab5abd849f02abac305d7a955/cpp/src/parquet/printer.cc#L254-L435
too?
It seems that we can use
https://github.com/simdjson/simdjson/blob/master/doc/builder.md#pretty-formatted-fractured-json
for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
