SAY-5 commented on PR #49832: URL: https://github.com/apache/arrow/pull/49832#issuecomment-5306864354
That gold value is 39 digits but only ~1.35e38, so it fits in 128 bits without wrapping. It's the digit count cap rejecting it, not a real overflow. Which makes me think the check is in the wrong place: if I detect the actual carry out of `ShiftAndAdd` instead, the wrapping cases from #49817 still get rejected, values like this one still parse, and I can drop the test edits to `PrintMaxValue`, `PrintMinValue` and the `Decimal256Test.WithNulls` constants as well. Do you want me to redo it that way, or keep the precision cap and let the integration JSON reader parse unscaled values through a permissive path? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
