Krishnanand-G opened a new pull request, #50900: URL: https://github.com/apache/arrow/pull/50900
### Rationale for this change #50859: with `ARROW_JSON=OFF`, parquet tools fail to link: `undefined reference to arrow::json::JsonWriter::GetString() const` `json_writer_internal.cc` was only compiled into the `ARROW_JSON` object library. Parquet still calls `JsonWriter` from `types.cc`, encryption, and geospatial helpers. `ARROW_PARQUET` already pulls in simdjson, so the writer can live outside the JSON feature flag. ### What changes are included in this PR? Move `json/json_writer_internal.cc` into a small `ARROW_JSON_WRITER` object library, built when `ARROW_JSON` or `ARROW_PARQUET` is on, and link it into libarrow. ### Are these changes tested? I did not run a full `ARROW_JSON=OFF` + Parquet extra build on this machine. The failure is a missing object in libarrow; Arrow CI (including jobs that set `ARROW_JSON=OFF`) is the check I am relying on. ### Are there any user-facing changes? No. * GitHub Issue: #50859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
