AarryaSaraf commented on PR #10690: URL: https://github.com/apache/arrow-rs/pull/10690#issuecomment-5335284123
> nit: im not sure the `test_offset_buffer_extend_from_dictionary_size_hint` is needed. the arithmetic makes sense and it already accounts for dividing by zero. this is essentially optionally pre-allocating space in a vector, nothing logically has changed. Agreed, removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
