CurtHagenlocher commented on code in PR #417: URL: https://github.com/apache/arrow-dotnet/pull/417#discussion_r3808849998
########## src/Apache.Arrow/Arrays/Time32Array.cs: ########## @@ -1,4 +1,4 @@ -// Licensed to the Apache Software Foundation (ASF) under one or moreDate32Array +// Licensed to the Apache Software Foundation (ASF) under one or moreDate32Array Review Comment: Good catch, and fixed in 2f0b60a. To be clear on provenance: this typo is pre-existing on `main`, not introduced by this PR. It dates to 71dc961 (ARROW-16660, #13279, June 2022), a copy-paste slip from the `Date32Array` template when `Time32Array`/`Time64Array` were added. Both files are byte-identical to `main` apart from the removed BOM. It surfaced here only because stripping the BOM put line 1 into the diff for the first time in four years — a nice side benefit of this change. These were the only two files in the repository with a malformed header line. ########## src/Apache.Arrow/Arrays/Time64Array.cs: ########## @@ -1,4 +1,4 @@ -// Licensed to the Apache Software Foundation (ASF) under one or moreDate32Array +// Licensed to the Apache Software Foundation (ASF) under one or moreDate32Array Review Comment: Good catch, and fixed in 2f0b60a. To be clear on provenance: this typo is pre-existing on `main`, not introduced by this PR. It dates to 71dc961 (ARROW-16660, #13279, June 2022), a copy-paste slip from the `Date32Array` template when `Time32Array`/`Time64Array` were added. Both files are byte-identical to `main` apart from the removed BOM. It surfaced here only because stripping the BOM put line 1 into the diff for the first time in four years — a nice side benefit of this change. These were the only two files in the repository with a malformed header line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
