WaterWhisperer opened a new pull request, #10749: URL: https://github.com/apache/arrow-rs/pull/10749
> AI disclosure: Codex(GPT-5.6) assisted with the regression test and verification. I reviewed and understand all changes and take responsibility for them. # Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes #10478. # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> REE arrays have no parent validity buffer, so nulls are valid only when both the REE field and its values field are nullable. Follows #10485, which was noted as stalled in [the issue](https://github.com/apache/arrow-rs/issues/10478#issuecomment-5265435201), and incorporates its outstanding review. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - Enforce the combined nullability of the REE field and its values field. - Add regression coverage for explicit nulls and missing fields across all nullability combinations. # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. --> Yes. - `cargo test -p arrow-json --all-features` - `cargo clippy --workspace --all-targets --all-features -- -D warnings` # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> Yes. The JSON decoder now rejects explicit nulls and missing fields that violate REE nullability. Such inputs were previously accepted, but there is no public API change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
