AlenkaF commented on issue #38868: URL: https://github.com/apache/arrow/issues/38868#issuecomment-5342198100
> `FixedShapeTensorScalar::ToTensor` is already implemented Also `FixedShapeTensorArray::ToTensor` is implemented. I think we should include these in the DLPack-facing tests (`array` -> `to_tensor` -> `__dlpack__`) that would fall under this ticket. > `PrimitiveArray::ToTensor` is missing I think this can be done as a follow-up if we see it is needed. As Joris mentioned, primitive arrays already have DLPack support. > How should we handle `FixedSizeList` ? Directly in `DLPack`, or add a fallible `Array::ToTensor`? I would go via `ToTensor`. > Possibly we want to add an error message recommending `to_tensor()` in DLPack when that is supported. Yes! > Would that be all that is required? I think so. Test should cover the full path from nested via `to_tensor` to `__dlpack__`, as already mentioned in this comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
