Reranko05 commented on code in PR #50874:
URL: https://github.com/apache/arrow/pull/50874#discussion_r3815618301
##########
cpp/src/arrow/extension/tensor_extension_array_test.cc:
##########
@@ -223,15 +223,15 @@ TEST_F(TestFixedShapeTensorType,
MetadataSerializationRoundtrip) {
// Validate shape values must be integers. Error message should include the
// JSON type name of the offending value.
CheckDeserializationRaises(ext_type_, storage_type, R"({"shape":[3.5,4]})",
- "shape must contain integers, got Number");
+ "shape must contain integers, got number");
Review Comment:
The shared helper uses simdjson's type names (number, string, etc.).
Changing them to RapidJSON's names (Number, String, etc.) would affect other
tests too, so I think we should keep the simdjson terminology here. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
