Rich-T-kid commented on code in PR #10763:
URL: https://github.com/apache/arrow-rs/pull/10763#discussion_r3816265558
##########
arrow/benches/cast_kernels.rs:
##########
@@ -257,6 +274,10 @@ fn add_benchmark(c: &mut Criterion) {
let string_array = build_string_array(512);
let wide_string_array = cast(&string_array, &DataType::LargeUtf8).unwrap();
+ let binary_low_card = build_binary_array_for_dict_cast(10_000, 25);
+ let binary_med_card = build_binary_array_for_dict_cast(10_000, 500);
+ let binary_high_card = build_binary_array_for_dict_cast(10_000, 2_500);
Review Comment:
would it be worth it to add a 100% unique case here?
##########
arrow/benches/cast_kernels.rs:
##########
@@ -257,6 +274,10 @@ fn add_benchmark(c: &mut Criterion) {
let string_array = build_string_array(512);
let wide_string_array = cast(&string_array, &DataType::LargeUtf8).unwrap();
+ let binary_low_card = build_binary_array_for_dict_cast(10_000, 25);
+ let binary_med_card = build_binary_array_for_dict_cast(10_000, 500);
+ let binary_high_card = build_binary_array_for_dict_cast(10_000, 2_500);
Review Comment:
or even as an extra case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
