alamb commented on code in PR #10755:
URL: https://github.com/apache/arrow-rs/pull/10755#discussion_r3817137168
##########
arrow-array/src/builder/generic_bytes_dictionary_builder.rs:
##########
@@ -214,9 +214,12 @@ where
Ok(Self {
state,
dedup,
- keys_builder: new_keys
- .into_builder()
- .expect("underlying buffer has no references"),
+ keys_builder: new_keys.into_builder().map_err(|_| {
Review Comment:
Can this actually happen? I think it is fine to make it a real error, but I
think it would be good to mark the error if it isn't actually expected (like
"Internal Error: source keys are ....")?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
