alamb commented on PR #10719: URL: https://github.com/apache/arrow-rs/pull/10719#issuecomment-5349660353
Some findings from a test upgrade - https://github.com/apache/datafusion/pull/24504 Specifically this commit: https://github.com/apache/datafusion/commit/419027d37c4a44b33bca045cd97cf14875bee137 This pattern comes up a bunch (to see if the index is "complete" it has to test both column_indexes and offset_indexes. ```rust metadata .page_index() .is_some_and(|index| index.has_column_indexes() && index.has_offset_indexes()) ``` Maybe we could add a helper like PageIndex::is_complete that does the check and we could simplify to ```rust metadata .page_index() .is_some_and(PageIndex::is_complete) ``` But otherwise the changes needed are pretty strightforward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
