emkornfield commented on code in PR #50916:
URL: https://github.com/apache/arrow/pull/50916#discussion_r3819092860
##########
cpp/src/parquet/arrow/schema_internal.cc:
##########
@@ -207,6 +207,8 @@ Result<std::shared_ptr<ArrowType>> FromFLBA(
return ::arrow::extension::uuid();
}
+ return ::arrow::fixed_size_binary(physical_length);
+ case LogicalType::Type::TIMESTAMP:
return ::arrow::fixed_size_binary(physical_length);
Review Comment:
I think this should probably be configurable. We should probably have a
mode that takes returns the arrow timestamp type (and either errors on overflow
or converts to MIN/MAX representable values., maybe a different config value?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
