emilk commented on code in PR #10759:
URL: https://github.com/apache/arrow-rs/pull/10759#discussion_r3823991316
##########
arrow-string/src/regexp.rs:
##########
@@ -461,17 +461,15 @@ pub fn regexp_match(
}
};
- if regex.is_none() {
Review Comment:
Again: forbidding all `.unwrap()`s is the only way to catch all of these.
I am personally a huge proponent of forbidding all `.unwrap()`:s - as this
PR shows, they are almost always hiding either a bug, or hiding a smarter and
faster way of doing something. But forbidding unwraps should be done on day one
of a code base, and doing it now might be too much work… but I might still try
in the future :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
