jorisvandenbossche commented on PR #50851: URL: https://github.com/apache/arrow/pull/50851#issuecomment-5367329083
> the pre-commit stuff is annoying (I just turn it off most of the time when developing locally) FWIW, my personal stance is that pre-commit in the first place is there to help the local developer. So if you are turning it off locally because it is annoying, we should fix it (on CI we can easily run the validation steps differently). One option is to still include those steps that are annoying locally, but have them not run by default and only run those on CI (we can mark those hooks as manual with `stages: [manual]`, and then run those explicitly on CI). For example we could keep the lintr cyclomatic complexity feature as a manual stage that is still run on CI (and we can still document the command for contributors to also run that locally). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
