etseidl commented on code in PR #10784:
URL: https://github.com/apache/arrow-rs/pull/10784#discussion_r3832637976
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -623,7 +623,7 @@ impl ArrowReaderOptions {
/// This method sets the same policy for both. For fine-grained control,
use
/// [`Self::with_column_index_policy`] and
[`Self::with_offset_index_policy`].
pub fn with_page_index_policy(self, policy: PageIndexPolicy) -> Self {
- self.with_column_index_policy(policy)
+ self.with_column_index_policy(policy.clone())
Review Comment:
The `clone`s are a consequence of adding a `HashSet` to the enum. The
`HashSet` is in an `Arc`, so the `clone` should be cheap, but it still looks
awkward. I might replace as many of these with references and clone internally
where I can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
