lidavidm commented on pull request #10354: URL: https://github.com/apache/arrow/pull/10354#issuecomment-843590735
> > One question I have is if we might want to still use `split_pattern` if we detect the pattern is not actually a regex, just so we don't invoke RE2/require an Arrow-with-RE2 build in all cases. > > @thisisnic did something similar in #10190, specifically https://github.com/apache/arrow/pull/10190/files#diff-3a791b6bbfdb1605c74f85ca5e9854503ed70ac8b274288919dfbec7ce0cef02R549-R552 Right, and currently this removes that check in favor of always dispatching to the new kernel unless `fixed = TRUE`. But we could keep that check and only dispatch if `fixed = FALSE` *and* the pattern is actually regex-like. That'd let you still use strsplit even if you built Arrow without RE2 in the same cases as before. It's a very minor point, though - maybe not worth doing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
