roee88 opened a new pull request #323:
URL: https://github.com/apache/arrow-rs/pull/323
Fix UB in FFI due to violation of aliasing rules
# Which issue does this PR close?
Closes #322.
# What changes are included in this PR?
- Fix the issue by using raw pointers derived from the Box objects in
private data rather than from moved boxes
- Enable MIRI in CI for most tests in arrow crate
`test result: ok. 78 passed; 0 failed; 0 ignored; 0 measured; 14
filtered out`
Specifically, the CI is changed to run miri test against the arrow crate
(only) while skipping some tests:
1. Individual tests that are either unsupported, fail, or get stuck are
ignored using `#[cfg_attr(miri, ignore)]` with a code comment that indicates
why it's disabled
2. IO tests (csv, json, ipc) are skipped in CI due to slowness and/or
failures.
The above was required because otherwise the CI would be stuck forever
(e.g., in the `test_can_cast_types` test). This wasn't the case so far because
the FFI issue failed the run. I suggest to track enabling more tests in #227.
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
