peterxcli opened a new pull request, #10810: URL: https://github.com/apache/arrow-rs/pull/10810
# Which issue does this PR close? - Closes #10802. # Rationale for this change The canonical `arrow.parquet.variant` extension permits Dictionary- and RunEndEncoded metadata, but `VariantArray` only accepted unencoded binary arrays. Downstream users therefore had to decode valid metadata eagerly before using Variant compute kernels. # What changes are included in this PR? - Accept Dictionary and RunEndEncoded metadata with Binary, LargeBinary, or BinaryView logical values. - Resolve encoded values and logical nulls in the shared metadata byte accessor. - Route `variant_to_json` through `VariantArray` so it shares the same validation and row access. - Add coverage for Dictionary/REE metadata, nulls, slices, `variant_get`, and `variant_to_json`. # Are these changes tested? - `cargo test -p parquet-variant-compute --lib` — 364 passed - `cargo test -p parquet-variant-compute --doc` — 13 passed - `cargo clippy -p parquet-variant-compute --all-targets -- -D warnings` - `cargo fmt --all -- --check` - `git diff --check` # Are there any user-facing changes? Yes. `VariantArray` and its compute kernels now accept canonical Dictionary- and RunEndEncoded metadata. There are no public API signature changes or breaking changes. # AI-assisted development Codex assisted with tracing callers, implementing the focused change, and drafting tests. I reviewed the resulting code and verified it with the checks above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
