emkornfield commented on code in PR #50252:
URL: https://github.com/apache/arrow/pull/50252#discussion_r3841131326
##########
cpp/src/arrow/extension/parquet_variant.h:
##########
@@ -18,15 +18,31 @@
#pragma once
#include <string>
+#include <string_view>
#include "arrow/extension_type.h"
#include "arrow/util/visibility.h"
namespace arrow::extension {
+/// \brief The extension name for the Variant extension type.
+inline constexpr std::string_view kVariantExtensionName =
"arrow.parquet.variant";
+
class ARROW_EXPORT VariantArray : public ExtensionArray {
public:
using ExtensionArray::ExtensionArray;
+
+ /// \brief The metadata child array.
+ std::shared_ptr<Array> metadata() const;
+
+ /// \brief The residual value child array, or null if it is absent from
storage.
+ std::shared_ptr<Array> value() const;
Review Comment:
Array here is an Arrow Array so it needs to be shared_ptr to integrate with
Arrow conventions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
