Rich-T-kid opened a new issue, #10815:
URL: https://github.com/apache/arrow-rs/issues/10815

   ### Is your feature request related to a problem or challenge?
   
   `arrow/benches/take_kernels.rs` is missing benchmarks for the following 
datatypes
   
   - fixed size list
   - map
   - union (sparse)
   - union (dense)
   - struct
   - dictionary 
   - REE
   
   Struct and dictionary types don't need specific benchmarks. 
`take(dictionary)` just routes through `take_native`, which is already 
benchmarked, and `take(struct)` simply calls `take()` repeatedly on its fields, 
so the benchmarks added in https://github.com/apache/arrow-rs/pull/10442 
already cover this case.
   
   ### Describe the solution you'd like
   
   benchmarks that cover all types
   
   ### Describe alternatives you've considered
   
   n/a
   
   ### Additional context
   
   https://github.com/apache/arrow-rs/pull/10441
   https://github.com/apache/arrow-rs/issues/8879


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to