lidavidm commented on a change in pull request #10118:
URL: https://github.com/apache/arrow/pull/10118#discussion_r635229033
##########
File path: python/pyarrow/dataset.py
##########
@@ -780,5 +784,5 @@ def write_dataset(data, base_dir, basename_template=None,
format=None,
_filesystemdataset_write(
scanner, base_dir, basename_template, filesystem, partitioning,
- file_options, max_partitions
+ file_options, use_threads, use_async, max_partitions
Review comment:
They should get passed into L744/L777 above, most likely.
##########
File path: r/R/dataset-scan.R
##########
@@ -42,6 +44,7 @@
#' - `$UseThreads(threads)`: logical: should the scan use multithreading?
#' The method's default input is `TRUE`, but you must call the method to enable
#' multithreading because the scanner default is `FALSE`.
+#' - `$UseAsync(use_async)`: logical: should the async scanner be used?
Review comment:
I think this is good now, thanks. (I confess I'm not exactly sure what R
needs.)
##########
File path: python/pyarrow/dataset.py
##########
@@ -780,5 +784,5 @@ def write_dataset(data, base_dir, basename_template=None,
format=None,
_filesystemdataset_write(
scanner, base_dir, basename_template, filesystem, partitioning,
- file_options, max_partitions
+ file_options, use_threads, use_async, max_partitions
Review comment:
If I'm not mistaken this'll be an error since those parameters don't
exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
