Copilot commented on code in PR #50979:
URL: https://github.com/apache/arrow/pull/50979#discussion_r3850438821
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -218,23 +218,6 @@ if(WIN32)
set(CXX_COMMON_FLAGS "/W3 /EHsc")
endif()
Review Comment:
This removes the suppression that protects builds using Windows SDK headers
which still trigger C5105 under MSVC's conforming preprocessor. Since
`CXX_COMMON_FLAGS` is applied globally and Debug CHECKIN/EVERYTHING builds add
`/WX` (lines 278-282), merely including those headers can now fail the build.
Please retain `/wd5105` until the supported Windows SDK baseline is known not
to emit this warning, or gate its removal on that baseline; enabling C++20/new
preprocessing alone does not guarantee it is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
