HuaHuaY commented on code in PR #50252:
URL: https://github.com/apache/arrow/pull/50252#discussion_r3851100273


##########
cpp/src/parquet/CMakeLists.txt:
##########
@@ -191,7 +190,20 @@ set(PARQUET_SRCS
     statistics.cc
     stream_reader.cc
     stream_writer.cc
-    types.cc)
+    types.cc
+    variant/array_internal.cc
+    variant/builder.cc
+    variant/decoding.cc
+    variant/shred.cc
+    variant/slot_internal.cc
+    variant/unshred.cc
+    variant/validate.cc
+    xxhasher.cc)
+
+if(MSVC)
+  set_source_files_properties(variant/builder.cc variant/slot_internal.cc
+                              PROPERTIES COMPILE_OPTIONS /Zc:preprocessor)

Review Comment:
   I have opened another PR to test this 
https://github.com/apache/arrow/pull/50979.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to