pitrou commented on code in PR #49372: URL: https://github.com/apache/arrow/pull/49372#discussion_r3853766921
########## cpp/src/arrow/filesystem/path_util.h: ########## @@ -159,9 +159,6 @@ std::string ToSlashes(std::string_view s); ARROW_EXPORT bool IsEmptyPath(std::string_view s); -ARROW_EXPORT -bool IsLikelyUri(std::string_view s); - Review Comment: Ok, I would rather the keep the declaration here, as "path utilities" is really where this function belongs IMHO. Also, it can stay in the `internal` namespace, as that will still be visible from PyArrow AFAIK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
