pratyushadk commented on code in PR #50907:
URL: https://github.com/apache/arrow/pull/50907#discussion_r3854116038
##########
python/pyarrow/tests/test_sparse_tensor.py:
##########
@@ -254,6 +257,27 @@ def test_sparse_csr_matrix_from_dense(dtype_str,
arrow_type):
assert np.array_equal(indices, result_indices)
[email protected](not csr_array, reason="requires scipy")
[email protected]('pa_class,sc_array_class', [
+ pytest.param(
+ pa.SparseCSRMatrix, csr_array, id='CSR'
+ ),
+ pytest.param(
+ pa.SparseCSCMatrix, csc_array, id='CSC'
+ ),
+])
+def test_sparse_csx_matrix_from_1d(pa_class, sc_array_class):
+ array = np.array([1, 0, 2, 0, 0, 3, 0, 4], dtype=np.int64)
+ tensor = pa.Tensor.from_numpy(array)
+
+ scipy_array = sc_array_class(array.reshape(1, -1))
Review Comment:
Thank you for the review and guidance, @rok. I'll make sure to open issues
and PRs with clearer motivations in future. Regarding the suggested change,
`csc_array(array)` raises `ValueError: CSC arrays don't support 1D input. Use
2D`, so the `reshape(1, -1)` is needed to construct both `csr_array` and
`csc_array` with matching `(1, n)` shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
