Copilot commented on code in PR #50949:
URL: https://github.com/apache/arrow/pull/50949#discussion_r3855545385
##########
compose.yaml:
##########
@@ -302,8 +302,10 @@ services:
volumes: &conda-volumes
- .:/arrow:delegated
- ${DOCKER_VOLUME_PREFIX}conda-ccache:/ccache:delegated
+ # WORKAROUND: Revert export after S3 is moved out of libarrow (GH-50194)
command: &conda-cpp-command
["
+ export ARROW_CMAKE_ARGS=-DCMAKE_VISIBILITY_INLINES_HIDDEN=ON &&
Review Comment:
The PR description says the fix is to prevent symbol interposition in
`arrow_s3fs` (linker `-Bsymbolic-functions` + making `kS3FileSystemModule`
static). This change instead forces `-DCMAKE_VISIBILITY_INLINES_HIDDEN=ON` in
the conda-cpp container, which looks like a CI workaround that should be either
(a) called out explicitly in the PR description/rationale, or (b) dropped if
the underlying fix makes it unnecessary.
##########
compose.yaml:
##########
@@ -302,8 +302,10 @@ services:
volumes: &conda-volumes
- .:/arrow:delegated
- ${DOCKER_VOLUME_PREFIX}conda-ccache:/ccache:delegated
+ # WORKAROUND: Revert export after S3 is moved out of libarrow (GH-50194)
command: &conda-cpp-command
["
+ export ARROW_CMAKE_ARGS=-DCMAKE_VISIBILITY_INLINES_HIDDEN=ON &&
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/cpp_test.sh /arrow /build"]
Review Comment:
This `export ARROW_CMAKE_ARGS=...` assignment overwrites any existing
`ARROW_CMAKE_ARGS` passed in from the environment (e.g. via `docker compose run
-e ARROW_CMAKE_ARGS=...`), which makes it hard to add additional ad-hoc CMake
options for conda-cpp runs. Consider appending instead and quoting to preserve
prior flags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
