RagingKore commented on issue #4715:
URL: https://github.com/apache/arrow-adbc/issues/4715#issuecomment-5412734047

   @CurtHagenlocher you own `/csharp/` and wrote #1843 and #1865, so this is 
probably yours.
   
   Does this cut across `AdbcStatement11`? I don't think it does. 
`AdbcDataReader.cs:396` is downstream of `QueryResult`, so the `.Result` 
survives a driver moving to 1.1. You built that API though, so tell me if 
that's wrong.
   
   On classification, I can see this being read as an enhancement. The 
`.Result` inside `ReadNextRecordBatchAsync` is a defect by itself; the two 
missing overrides arguably aren't. I called the combination a bug because the 
awaited path deadlocks on a `SynchronizationContext`, and the report has a 
captured stack. I also filed through the CLI, so the template never applied 
`Type: bug` and I can't set it myself.
   
   Either way I'll open the PR. Three changes in `csharp/src/Client/`, nothing 
in the drivers.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to