jduo commented on a change in pull request #9368: URL: https://github.com/apache/arrow/pull/9368#discussion_r635404836
########## File path: java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSQLClientUtils.java ########## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.arrow.flight.sql; + +import java.io.Closeable; +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; + +import org.apache.arrow.flight.Action; +import org.apache.arrow.flight.FlightClient; +import org.apache.arrow.flight.FlightDescriptor; +import org.apache.arrow.flight.FlightInfo; +import org.apache.arrow.flight.Result; +import org.apache.arrow.flight.sql.impl.FlightSQL; +import org.apache.arrow.flight.sql.impl.FlightSQL.ActionGetPreparedStatementResult; +import org.apache.arrow.flight.sql.impl.FlightSQL.ActionGetTablesRequest; +import org.apache.arrow.flight.sql.impl.FlightSQL.ActionGetTablesResult; +import org.apache.arrow.flight.sql.impl.FlightSQL.CommandPreparedStatementQuery; +import org.apache.arrow.vector.types.pojo.Schema; + +import com.google.protobuf.Any; +import com.google.protobuf.ByteString; + +import io.grpc.Status; + +/** + * Client side utilities to work with Flight SQL semantics. + */ +public final class FlightSQLClientUtils { + + /** + * Helper method to request a list of tables from a Flight SQL enabled endpoint. + * + * @param client The Flight Client. + * @param catalog The catalog. + * @param schemaFilterPattern The schema filter pattern. + * @param tableFilterPattern The table filter pattern. + * @param tableTypes The table types to include. + * @param includeSchema True to include the schema upon return, false to not include the schema. + * @return A list of tables matching the criteria. + */ + public static List<ActionGetTablesResult> getTables(FlightClient client, String catalog, String schemaFilterPattern, + String tableFilterPattern, List<String> tableTypes, boolean includeSchema) { + + final ActionGetTablesRequest.Builder requestBuilder = ActionGetTablesRequest + .newBuilder() + .setIncludeSchema(includeSchema); + + if (catalog != null) { + requestBuilder.setCatalog(catalog); + } + + if (schemaFilterPattern != null) { + requestBuilder.setSchemaFilterPattern(schemaFilterPattern); + } + + if (tableFilterPattern != null) { + requestBuilder.setTableNameFilterPattern(tableFilterPattern); + } + + if (tableTypes != null) { + requestBuilder.addAllTableTypes(tableTypes); + } + + final Iterator<Result> results = client.doAction(new Action( + "GetTables", Any.pack(requestBuilder.build()).toByteArray())); + + final List<ActionGetTablesResult> getTablesResults = new ArrayList<>(); + results.forEachRemaining(result -> { Review comment: This should be done lazily instead of caching everything in an ArrayList. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
