zanmato1984 commented on PR #47391: URL: https://github.com/apache/arrow/pull/47391#issuecomment-5419246657
@pitrou Yes, I think the capability itself is reasonable. Feature columns produced by pivot-longer can naturally contain typed values, for example integer week numbers, dates, or timestamps. Forcing them through strings loses type information and requires downstream casts. Keeping the `vector<string>` constructor also preserves the common existing spelling. I left one inline comment about handling null scalar pointers safely. Also, since the public `feature_values` member type changes, I think the `Breaking Change` label should be added even though the legacy constructor is retained. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
