zhangxinyao88 opened a new pull request, #10851: URL: https://github.com/apache/arrow-rs/pull/10851
# Which issue does this PR close? - Part of #10245. # Rationale for this change This replaces one of the remaining `BufferBuilder` callsites listed in #10245. Using `Vec` for the offsets avoids the builder overhead while preserving the resulting `ScalarBuffer`. # What changes are included in this PR? `decode_binary` now constructs its offsets with `Vec<I>` instead of `BufferBuilder<I>`. # Are these changes tested? Yes: - `cargo fmt --all -- --check` - `cargo test -p arrow-row` — 95 unit tests and 8 doc tests passed - `cargo clippy -p arrow-row --all-targets --all-features -- -D warnings` Existing round-trip tests cover the changed path, so no new tests were added. Benchmark: `convert_rows 4096 string(100, 0)` | | Time | | --- | ---: | | `main` | 47.769 µs | | This PR | 45.488 µs | Criterion reported a 4.4% improvement. # Are there any user-facing changes? No. # AI assistance Codex was used to identify the callsite, prepare the focused refactor, run validation, and draft this description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
