Jefffrey commented on code in PR #10840:
URL: https://github.com/apache/arrow-rs/pull/10840#discussion_r3860167961
##########
arrow-schema/src/datatype_display.rs:
##########
@@ -174,10 +174,13 @@ impl Display for DataType {
}
Self::RunEndEncoded(run_ends_field, values_field) => {
write!(f, "RunEndEncoded(")?;
- let run_ends_str = format_field(run_ends_field);
let values_str = format_field(values_field);
- write!(f, "{run_ends_str}, {values_str})")?;
+ write!(
Review Comment:
what if we follow how list formats it by doing
`RunEndEncoded(Int32, non-null String)`
and then we expand to the verbose form if we have different names for the
fields, other than the default
`RunEndEncoded('run_ends': Int32, "named_values": non-null String)`
i know i suggested omitting the `non-null` for key since thats enforced, but
i wonder if that just causes confusion and maybe we're better off leaving it in
🤔
another thing to consider is would this new format roundtrip through
parsing? i dont know if we have existing 100% guarantee that all formatted
displays can also be parsed, but maybe thats something we should aim for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
