Jay846 commented on code in PR #50976:
URL: https://github.com/apache/arrow/pull/50976#discussion_r3861277791
##########
cpp/src/arrow/compute/kernels/scalar_cast_test.cc:
##########
@@ -3646,6 +3646,72 @@ TEST(Cast, ListToListOptionsPassthru) {
}
}
+TEST(Cast, ListViewToList) {
Review Comment:
Actually, my bad! I updated the PR description but completely forgot to
update the main issue page. Just edited the description on the issue now (first
timer creating new Issue and was not aware that we have to change accordingly).
Also, let me check about the static_cast in the overflow check. Since it's
already cast, that check is dead code. I'll check the raw source offset value
before the cast and push a fix shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
