alamb commented on issue #364: URL: https://github.com/apache/arrow-datafusion/issues/364#issuecomment-844373242
> Would we change ScalarValue to store OrderedFloat and add Eq in addition to PartialOrd and Ord or keep using raw floats and only define PartialOrd? I would suggest we don't change ScalarValue in this PR and use GroupByScalar, When we get to unifying GroupByScalar and ScalarValue I would imagine we would have to use `ordered_float` in ScalarValue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
