alamb commented on code in PR #10867:
URL: https://github.com/apache/arrow-rs/pull/10867#discussion_r3866020094
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -2846,11 +2846,11 @@ where
TO::PREFIX
))
})?;
- offset_builder.append(offset);
+ cast_offsets.push(offset);
Ok(())
})?;
- let offset_buffer = offset_builder.finish();
+ let offset_buffer = arrow_buffer::Buffer::from_vec(cast_offsets);
Review Comment:
I agree it would be nice to use the un prefixed form
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
