birschick-bq commented on code in PR #4661:
URL: https://github.com/apache/arrow-adbc/pull/4661#discussion_r3866381292
##########
go/adbc/driver/flightsql/flightsql_statement.go:
##########
@@ -483,35 +484,43 @@ func (s *statement) SetOptionDouble(key string, value
float64) error {
// The query can then be executed with any of the Execute methods.
// For queries expected to be executed repeatedly, Prepare should be
// called before execution.
-func (s *statement) SetSqlQuery(query string) error {
+func (s *statement) SetSqlQuery(query string) (err error) {
Review Comment:
I'm taking to mean that we don't need to trace that we called `SetSqlQuery`.
So I removed tracing from this function. Correct me if I'm wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
